Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: prepare v0.53.0 #4796

Merged
merged 1 commit into from
Nov 5, 2023
Merged

chore: prepare v0.53.0 #4796

merged 1 commit into from
Nov 5, 2023

Conversation

mxinden
Copy link
Member

@mxinden mxinden commented Nov 5, 2023

Description

Notes & open questions

Closes #4545

Change checklist

  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • A changelog entry has been made in the appropriate crates

@mxinden mxinden added send-it trivial Marks PRs which are considered trivial and don't need approval from another maintainer. internal-change Pull requests that make internal changes to crates and thus don't need to include a changelog entry. labels Nov 5, 2023
@mergify mergify bot merged commit 74e3157 into libp2p:master Nov 5, 2023
71 checks passed
@mxinden
Copy link
Member Author

mxinden commented Nov 5, 2023

I published and tagged the following crates:

  • futures-bounded-v0.2.1
  • hole-punching-tests-v0.1.0
  • libp2p-allow-block-list-v0.3.0
  • libp2p-autonat-v0.12.0
  • libp2p-connection-limits-v0.3.0
  • libp2p-core-v0.41.0
  • libp2p-dcutr-v0.11.0
  • libp2p-dns-v0.41.0
  • libp2p-floodsub-v0.44.0
  • libp2p-gossipsub-v0.46.0
  • libp2p-identify-v0.44.0
  • libp2p-kad-v0.45.0
  • libp2p-mdns-v0.45.0
  • libp2p-memory-connection-limits-v0.2.0
  • libp2p-metrics-v0.14.0
  • libp2p-mplex-v0.41.0
  • libp2p-noise-v0.44.0
  • libp2p-perf-v0.3.0
  • libp2p-ping-v0.44.0
  • libp2p-plaintext-v0.41.0
  • libp2p-pnet-v0.24.0
  • libp2p-quic-v0.10.0
  • libp2p-relay-v0.17.0
  • libp2p-rendezvous-v0.14.0
  • libp2p-request-response-v0.26.0
  • libp2p-swarm-derive-v0.34.0
  • libp2p-swarm-test-v0.3.0
  • libp2p-swarm-v0.44.0
  • libp2p-tcp-v0.41.0
  • libp2p-tls-v0.3.0
  • libp2p-uds-v0.40.0
  • libp2p-upnp-v0.2.0
  • libp2p-v0.53.0
  • libp2p-websocket-v0.43.0
  • libp2p-websocket-websys-v0.3.0
  • libp2p-webtransport-websys-v0.2.0
  • libp2p-yamux-v0.45.0

I was not able to publish libp2p-webrtc-websys:

error[E0277]: `?` couldn't convert the error to `error::Error`
  --> src/upgrade.rs:51:97
   |
51 |     let peer_id = noise::outbound(id_keys, channel, remote_fingerprint, local_fingerprint).await?;
   |                                                                                                 ^ the trait `From<libp2p_noise::Error>` is not implemented for `error::Error`
   |
   = note: the question mark operation (`?`) implicitly performs a conversion on the error value using the `From` trait
   = help: the following other types implement trait `From<T>`:
             <error::Error as From<wasm_bindgen::JsValue>>
             <error::Error as From<libp2p_noise::Error>>
             <error::Error as From<std::io::Error>>
             <error::Error as From<String>>
   = note: required for `Result<(PeerId, Connection), error::Error>` to implement `FromResidual<Result<Infallible, libp2p_noise::Error>>`

For more information about this error, try `rustc --explain E0277`.

I will debug this further tomorrow. //CC @thomaseizinger in case you have an idea.

@thomaseizinger
Copy link
Contributor

I will debug this further tomorrow. //CC @thomaseizinger in case you have an idea.

Might perhaps be a missing std feature flag somewhere so it doesn't implement std::error::Error?

@mxinden
Copy link
Member Author

mxinden commented Nov 8, 2023

I will debug this further tomorrow. //CC @thomaseizinger in case you have an idea.

Might perhaps be a missing std feature flag somewhere so it doesn't implement std::error::Error?

Turns out, we never actually bumped the libp2p-webrtc-websys version:

version = "0.2.0-alpha"

v0.2.0-alpha is already on crates.io.

@thomaseizinger
Copy link
Contributor

I think that is because we exclude alphas anyway and can release them at any time, yeah?

umgefahren pushed a commit to umgefahren/rust-libp2p that referenced this pull request Mar 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
internal-change Pull requests that make internal changes to crates and thus don't need to include a changelog entry. send-it trivial Marks PRs which are considered trivial and don't need approval from another maintainer.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

v0.53 release
2 participants